Restore Bit perfect read/write ability #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her Maniac fields. Not 100% sure why the value is 0 for all the maniac fields, probably because we support Maniac Patch in RPG2k.
Otherwise this is written into all files manipulated with our tools. This change restores the bit perfect read/write achieved in EasyRPG#242
fdelapena
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #484 I removed the dust from my old diff tool used in #242 and noticed that the files differ after a load-save-operation with liblcf.
A few of our custom chunks were set to PersistIfDefault (always write, even when default value), so they were added to all database files processed by liblcf (e.g. lcf2xml).
This didn't damage the files but was a useless addition which increased the filesize.
Now the files are perfect again :) (= a read-write-cycle changes nothing in the files)